Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add consul module #104

Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: add consul module #104

merged 2 commits into from
Mar 22, 2024

Conversation

ruslansennov
Copy link
Contributor

HashiCorp Consul
https://www.consul.io/

DDtKey
DDtKey reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

src/consul/mod.rs Show resolved Hide resolved
@ruslansennov
Copy link
Contributor Author

@DDtKey should I do anything else?

@DDtKey DDtKey changed the title add consul module feat: add consul module Mar 22, 2024
@DDtKey DDtKey merged commit 6453ac7 into testcontainers:main Mar 22, 2024
5 of 6 checks passed
@DDtKey
Copy link
Contributor

DDtKey commented Mar 22, 2024

No, that's alright. I changed PR name to match rules of conventional commits

Thank you! 👍

@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Merged
@ruslansennov ruslansennov deleted the consul-init branch March 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDtKey DDtKey DDtKey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruslansennov @DDtKey