-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cockroachdb image impl #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 🙏
Just one topic I want to discuss: image arguments.
I changed the name of PR to fit conventional commits. Don't worry about this.
But please apply rustfmt 🙂
Co-authored-by: Artem Medvedev <i@ddtkey.com>
Made suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
Thanks for the contribution :) I had a quick look and added one comment, open for discussion. |
## 🤖 New release * `testcontainers-modules`: 0.3.6 -> 0.3.7 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.7] - 2024-04-05 ### Features - Add cockroachdb image impl ([#109](#109)) - Add `CNCF Distribution` module ([#111](#111)) ### Miscellaneous Tasks - Update reqwest requirement from 0.11.23 to 0.12.1 ([#106](#106)) - Update mysql requirement from 24.0.0 to 25.0.0 ([#107](#107)) - Update zookeeper-client requirement from 0.6.0 to 0.7.1 ([#110](#110)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
## 🤖 New release * `testcontainers-modules`: 0.3.6 -> 0.3.7 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.7] - 2024-04-06 ### Features - Add cockroachdb image impl ([#109](#109)) - Add `CNCF Distribution` module ([#111](#111)) ### Miscellaneous Tasks - Update reqwest requirement from 0.11.23 to 0.12.1 ([#106](#106)) - Update mysql requirement from 24.0.0 to 25.0.0 ([#107](#107)) - Update zookeeper-client requirement from 0.6.0 to 0.7.1 ([#110](#110)) - Define version for bollard to meet crates.io constraints ([#115](#115)) ### Revert - Rollback version to apply a fix before releasing ([#114](#114)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Adds Cockroach DB module