Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mariadb module #127

Merged
merged 1 commit into from
May 2, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented May 2, 2024

This PR adds a module for MariaDB. I recently added support for MariaDB to rsql and would like to add integration tests for the driver.

@mervyn-mccreight mervyn-mccreight self-assigned this May 2, 2024
Copy link
Contributor

@mervyn-mccreight mervyn-mccreight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🚀 .
Looks good to me, I will release it ASAP.

@mervyn-mccreight mervyn-mccreight merged commit 7ae56e5 into testcontainers:main May 2, 2024
6 checks passed
@brianheineman
Copy link
Contributor Author

Thanks for the quick review @mervyn-mccreight and the great project; much appreciated!

@brianheineman brianheineman deleted the mariadb branch May 2, 2024 22:21
@github-actions github-actions bot mentioned this pull request May 2, 2024
mervyn-mccreight pushed a commit that referenced this pull request May 2, 2024
## 🤖 New release
* `testcontainers-modules`: 0.4.1 -> 0.4.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.4.2] - 2024-05-02

### Features

- Add mariadb module
([#127](#127))

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mervyn-mccreight
Copy link
Contributor

It is released @brianheineman: https://github.com/testcontainers/testcontainers-rs-modules-community/releases/tag/v0.4.2 🥳

@brianheineman
Copy link
Contributor Author

Wow, thanks for the fast release @mervyn-mccreight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants