docs(localstack): fix localstack example by setting force_path_style
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDtKey
reviewed
May 10, 2024
DDtKey
changed the title
force_path_style
DDtKey
reviewed
May 10, 2024
| .region(region_provider) | ||
|
|
||
| let config = aws_sdk_s3::config::Builder::default() | ||
| .behavior_version(BehaviorVersion::v2024_03_28()) |
There was a problem hiding this comment.
This one, in fact - not required change, because depends on your Cargo.lock (e.g - I have aws-smithy-runtime 1.1.6 in it - where v2024_03_28 doesn't present, and it corresponds to minimal versions declared in Cargo.toml).
But let's keep it, since it's more fresh version
|
Thank you for the contribution! 🙏 |
Merged
DDtKey
pushed a commit
that referenced
this pull request
May 12, 2024
## 🤖 New release * `testcontainers-modules`: 0.4.2 -> 0.4.3 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.4.3] - 2024-05-12 ### Documentation - Fix localstack example by setting `force_path_style` ([#132](#132)) ### Features - Add kwok module ([#121](#121)) - K3s module ([#129](#129)) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131, where I discovered the
localstackexample is broken when running:Some research brought me to awslabs/aws-sdk-rust#1138, which uncovered that
create_bucketis broken here becauselocalstackuses the soon-to-be-deprecated "path-style" address style rather than the newer "virutal-hosted" style.I reworked the configuration in the example to set
force_path_style(true), which fixescreate_bucket. The example now runs successfully.I also updated the
BehaviorVersion, because the currently referenced one is now deprecated and was causing a warning.