feat: add Hashicorp Vault test container and test #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasondemorrow
changed the title
|
Tests in untouched code are failing, perhaps due to added tracing dep? That doesn't make sense, but it's all I can think of. |
|
Overrode my local 1.79 with 1.75 to match CI, but now aws-sqs won't build b/c it needs 1.76+? |
|
I see what happened here. I had the distinct misfortune of issuing a PR just as the upgrade to TC 0.18 landed in main 😂 |
DDtKey
approved these changes
Jun 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also adds tracing library to dev deps b/c I wanted to see the TC logs and figured others might too