Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mysql image #50

Merged
merged 9 commits into from
Oct 23, 2023
Merged

Conversation

dlen
Copy link
Contributor

@dlen dlen commented Oct 20, 2023

Hello!

I think mysql image is missing and it could come handy (code is very much the same as psql image). Let me know what you think!

Thanks for maintaining all these images!

Copy link
Contributor

@DDtKey DDtKey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Yes, it makes sense to add mysql.

src/mysql/mod.rs Show resolved Hide resolved
src/mysql/mod.rs Outdated Show resolved Hide resolved
src/mysql/mod.rs Outdated Show resolved Hide resolved
src/mysql/mod.rs Outdated Show resolved Hide resolved
dlen and others added 3 commits October 20, 2023 18:58
Co-authored-by: Artem Medvedev <i@ddtkey.com>
Co-authored-by: Artem Medvedev <i@ddtkey.com>
src/mysql/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Artem Medvedev <i@ddtkey.com>
@DDtKey DDtKey changed the title Added mysql image feat: add mysql image Oct 21, 2023
@DDtKey DDtKey merged commit 977c19e into testcontainers:main Oct 23, 2023
6 checks passed
@dlen dlen deleted the feature/mysql-image branch October 23, 2023 10:44
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
DDtKey pushed a commit that referenced this pull request Oct 23, 2023
## 🤖 New release
* `testcontainers-modules`: 0.1.2 -> 0.1.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.1.3] - 2023-10-23

### Documentation

- Fix repository URL
- Add documentation for postgres image
([#51](#51))

### Features

- Add mysql image
([#50](#50))

### Miscellaneous Tasks

- Update aws-sdk-sqs requirement from 0.31.1 to 0.33.0
([#47](#47))
- Update aws-sdk-s3 requirement from 0.31.2 to 0.33.0
([#48](#48))
- Update aws-sdk-dynamodb requirement from 0.31.1 to 0.33.0
([#49](#49))

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@DDtKey
Copy link
Contributor

DDtKey commented Oct 23, 2023

Released as part of 0.1.3 version: https://github.com/testcontainers/testcontainers-rs-modules-community/releases/tag/v0.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants