Entrypoint customization #174
Conversation
| let docker = clients::Cli::default(); | ||
| let msg = images::generic::WaitFor::message_on_stdout("server is ready"); | ||
|
|
||
| let generic = images::generic::GenericImage::new("tumdum/simple_web_server:latest") |
There was a problem hiding this comment.
Is this image going to be supported for longer?
I wouldn't want to depend on an image for our tests that breaks or is removed eventually :)
It would be nice to depend on one of the standard images like alpine for these tests.
There was a problem hiding this comment.
I've created it just for this pull request, source is here: https://git.sr.ht/~ttt/simple_web_server
There was a problem hiding this comment.
Thanks!
If it is specifically designed for this purpose, it would be nice if we could colocate the source with the test.
Do you mind including it in this repository? I was thinking of using a cargo buildscript to build (and tag) the container at build time so it is available for the test!
There was a problem hiding this comment.
@thomaseizinger Building container in build script can lead to a situation where after building, user removes all local containers and later reruns tests only to find out that they no longer pass. Is this an desired behaviour?
There was a problem hiding this comment.
That is a very rare situation no?
By default, build scripts are run on every invocation anyway unless we make use of some of the "change detection" mechanisms.
Given that container builds through docker are idempotent, this should be relatively fast.
We would have to opt out from the buildscript in non-test cases. No sure if that is possible.
There was a problem hiding this comment.
move all the tests to a separate crate and include the buildscript in there :)
You want to have this change done in this pull request?
There was a problem hiding this comment.
move all the tests to a separate crate and include the buildscript in there :)
You want to have this change done in this pull request?
I saw you licensed the image source as A-GPL. To my knowledge, that is not compatible with the MIT or Apache2 license in this repository.
If you are ok with me taking the source of the docker image and putting it into this repository despite the license then we can merge the PR as is! I guess we would have to drop A-GPL then? Not sure about this to be honest.
If you are keen to introduce a testing crate as described above then even better but it is not a requirement from my side :)
There was a problem hiding this comment.
If you are ok with me taking the source of the docker image and putting it into this repository despite the license then we can merge the PR as is! I guess we would have to drop A-GPL then? Not sure about this to be honest.
I'm completely fine with that - you can use that code as if it was licensed under either MIT or Apache2 license.
Do you need me to change license in that repo or is my written permission here enough?
There was a problem hiding this comment.
That is good enough, thank you :)
I am happy to merge this as is then!
There was a problem hiding this comment.
Thanks for your contribution and patience :)
|
bors r+ |
|
Build succeeded: |
Extend
Imageso that it is possible to customizeentrypointused by image.