chore: rid of deprecated class #209
Conversation
andreezy777
changed the title
andreezy777
force-pushed
the
update_kafka_container
branch
from
fc326a0
to
55c2580
Compare
|
|
||
| class KafkaContainer(confluentPlatformVersion: Option[String] = None, | ||
| externalZookeeper: Option[String] = None) extends SingleContainer[JavaKafkaContainer] { |
There was a problem hiding this comment.
Has this argument been removed on purpose? It doesn't seem to be deprecated in the Java lib
There was a problem hiding this comment.
Are you about externalZookeeper?
If yes. Then by default externalZookeeperConnect = null in Java lib, so then we do not need pass any value, cause by default we will use embeddedZookeeper (because method withEmbeddedZookeeper returns externalZookeeperConnect = null).
And if anyone wants to use externalZookeeper they should use configure method (as written above the val kafkaContainer )
There was a problem hiding this comment.
Sorry for vague question, and yes, I was asking about externalZookeeperConnect.
Thank you, it makes sense!
|
@andreezy777 Thank you! Added a quick comment |
|
@dimafeng Thanks for quick response, add a comment for your question. |
|
|
Hi, here is my proposal to change deprecated
JavaKafkaContainerclass with String argument to newer class withDockerImageNameargument. (like in ElasticSearch module)