Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Push down dependencies into requiring packages so that errors show up early #336

Closed
silkentrance opened this issue Nov 10, 2022 · 0 comments · Fixed by #341
Closed
Assignees
Labels
internal Some internal task/chore
Milestone

Comments

@silkentrance
Copy link
Member

silkentrance commented Nov 10, 2022

ATM we have top level dependencies in our private package that are shared with the other packages.

In the past it showed that errors popped up late in the development cycle, concerning package dependencies.

All package dependencies that are not needed by the top level package must therefore be pushed down into the respective requiring packages.

E.g. @types/mocha is not required by packages other than @testdeck/mocha on so on. Similarly so nyc, eslint and so on.

At the top level we only require lerna and supplemental lerna packages such as lerna-changelog and so on.

@silkentrance silkentrance added the internal Some internal task/chore label Nov 10, 2022
@silkentrance silkentrance mentioned this issue Nov 10, 2022
12 tasks
silkentrance added a commit that referenced this issue Nov 11, 2022
silkentrance added a commit that referenced this issue Nov 11, 2022
silkentrance added a commit that referenced this issue Nov 11, 2022
@silkentrance silkentrance self-assigned this Nov 11, 2022
@silkentrance silkentrance added this to the v0.3.3 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Some internal task/chore
Projects
None yet
1 participant