Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Reconfigure Package Scripts #353

Closed
silkentrance opened this issue Nov 11, 2022 · 0 comments · Fixed by #354
Closed

[INTERNAL] Reconfigure Package Scripts #353

silkentrance opened this issue Nov 11, 2022 · 0 comments · Fixed by #354
Assignees
Labels
internal Some internal task/chore
Milestone

Comments

@silkentrance
Copy link
Member

silkentrance commented Nov 11, 2022

  • prepare running tsc causes issues during lerna-bootstrap which is run on postinstall
  • running lint after test is somewhat obscure, needs to be run before test
  • prior to lerna-publish we must make sure that the packages install, lint, build and test correctly from a clean-all work directory

Root Package

  "scripts": {
    "postinstall": "lerna bootstrap --no-ci",
    "build": "lerna run build",
    "clean": "lerna run clean",
    "clean-all": "lerna run clean-all && npx rimraf node_modules || true",
    "test": "lerna run test --verbose",
    "lint": "lerna run lint",
    "lint-fix": "lerna run lint-fix",
    "prelerna-publish": "npm run clean-all && npm run install && npm run build && npm run test",
    "lerna-publish": "lerna publish",
    "changelog": "lerna-changelog"
  }
@silkentrance silkentrance added the internal Some internal task/chore label Nov 11, 2022
@silkentrance silkentrance self-assigned this Nov 11, 2022
silkentrance added a commit that referenced this issue Nov 11, 2022
@silkentrance silkentrance linked a pull request Nov 11, 2022 that will close this issue
silkentrance added a commit that referenced this issue Nov 11, 2022
@silkentrance silkentrance added this to the v0.3.3 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Some internal task/chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant