Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Use @options (not @data) per Grunt guidelines #2

Merged
merged 4 commits into from
Dec 6, 2013

Conversation

jasonkarns
Copy link
Member

To get target > task > default option merging out of the box, you have to
use options when configuring; as opposed to putting the settings directly
on the target. Then, within the task, use this.options([defaults]).

To get target > task > default option merging out of the box, you have
to use `options` when configuring; as opposed to putting the settings directly on
the target. Then, within the task, use `this.options([defaults])`.
@searls
Copy link
Member

searls commented Nov 10, 2013

Hehe, I got those guidelines into the readme because of their use of @DaTa and then I forgot to update this module. Nice

On Sun, Nov 10, 2013 at 3:57 PM, Jason Karns notifications@github.com
wrote:

To get target > task > default option merging out of the box, you have to
use options when configuring; as opposed to putting the settings directly
on the target. Then, within the task, use this.options([defaults]).
You can merge this Pull Request by running:
git pull https://github.com/jasonkarns/grunt-jasmine-bundle options
Or you can view, comment on it, or merge it online at:
#2
-- Commit Summary --

@jasonkarns
Copy link
Member Author

Fair warning, this isn't backwards compatible. Any task configuration already using the old style won't get picked up correctly.

@jasonkarns
Copy link
Member Author

I tried to tie this PR to #1, but apparently you can only submit PRs to issues created by you.

@searls
Copy link
Member

searls commented Nov 10, 2013

Ah. We could make this BC easily enough

On Sun, Nov 10, 2013 at 4:00 PM, Jason Karns notifications@github.com
wrote:

Fair warning, this isn't backwards compatible. Any task configuration already using the old style won't get picked up correctly.

Reply to this email directly or view it on GitHub:
#2 (comment)

@jasonkarns
Copy link
Member Author

Now backwards compatible. (and warns if using the old style config)

@davemo
Copy link
Contributor

davemo commented Nov 11, 2013

👍

@jasonkarns
Copy link
Member Author

cleaned up the commits and plucked out the unrelated stuff.

ready to merge

searls added a commit that referenced this pull request Dec 6, 2013
@searls searls merged commit 0513d32 into testdouble:master Dec 6, 2013
@searls
Copy link
Member

searls commented Dec 6, 2013

Merged on faith

@jasonkarns jasonkarns deleted the options branch December 6, 2013 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants