Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Node v20.6.0 ability to auto-register loader #102

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

giltayar
Copy link
Collaborator

@giltayar giltayar commented Sep 6, 2023

Node.js v20.6.0 has the ability to register a loader and thus auto load it without the user needing to --loader it (nodejs/node#46826).

I implemented the changes necessary for this, while supporting the old --loader interface for both new and old Node.js versions. So the tests run without --loader if running under a node version that supports registering, and also with --loader for all versions.

(note that the code is getting hairier with every change in the loader specification. Hopefully, once 20 will become the oldest version we can do a clean sweep that will remove all this cruft, because it seems that the loader API has finally stabilized)

As usual, once quibble is released, I'll test and update testdouble.js with the new version and also update its documentation.

@searls
Copy link
Member

searls commented Sep 6, 2023

Thanks for all this @giltayar!

@giltayar
Copy link
Collaborator Author

@searls not sure about the protocol here. Do I merge? I'm assuming you need to create the version, because I don't have NPM permissions?

@giltayar giltayar merged commit 06e1fcd into main Sep 12, 2023
6 checks passed
@giltayar giltayar deleted the support-register branch September 12, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants