Allow for user-provided args. Issue #5 #6
Conversation
deanrad
force-pushed
the
pass-through-args
branch
from
532d2d7
to
b87093a
Compare
|
Will merge once we have an safe / integration test for the behavior. |
|
(The appveyor status failure can be disregarded until our windows PR is done) |
|
One thing remaining - documentation |
|
Nice test! Be sure to remove scripts/args/user... tho or else every user will get it!!! |
|
~~ There, tied up with a 🙇 ~~ |
Verify that user-provided args are passed through if script references $@ Readme and cleanup
deanrad
force-pushed
the
pass-through-args
branch
from
e59b347
to
0d7c99a
Compare
| runScripty('args:echoer', {userArgs: ['--test', 'arg passed by user']}, function (er, code, stdio) { | ||
| assert.includes(stdio.stdout, '--test arg passed by user') | ||
| }) | ||
| done(null) |
There was a problem hiding this comment.
This done(null) needs to be inside runScripty's callback after the assertion (or it will exit prematurely) and called with done(er) so it'll fail if anything errors
|
Just gave some line comments. Sorry for giving you such a hard time with this |
|
I knew that's what you referred to on twitter ;) |
|
I have also sent you slack DMs out of an abundance of caremad. |
|
Alright and just to create even more work for you, the appveyor windows build is now passing, so we should get this one passing too before merge. Any new example scripts in the integration tests need to be provided in the new fixture directories for windows (with |
|
Closing to go work in #12 (you have commit bit now if you want to push to it) |
See Issue #5