Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise stubbing sugar #115

Merged
merged 5 commits into from Jul 13, 2016
Merged

Promise stubbing sugar #115

merged 5 commits into from Jul 13, 2016

Conversation

searls
Copy link
Member

@searls searls commented Jul 13, 2016 •
edited

  • add promise stubbing sugar
  • add configuration property for choosing your own promise constructor
  • test it
  • add warning + error for folks who don't set a promise constructor on runtimes that lack a native one
  • document it

Resolves #46

@jasonkarns
Copy link
Member

If it's anything like what I saw in our slack convo, i'm going to blindly 👍 on trust.

@searls
Copy link
Member Author

searls commented Jul 13, 2016

merging even though @Schoonology raised an issue with my crappy git messages

@searls searls merged commit c3959a1 into master Jul 13, 2016
@searls searls deleted the promises branch July 13, 2016 20:10
@Schoonology
Copy link
Contributor

Finally finished reviewing. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@searls @jasonkarns @Schoonology