Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out replacement of especially 6+ Classes #158

Merged
merged 12 commits into from
Dec 11, 2016
Merged

Sort out replacement of especially 6+ Classes #158

merged 12 commits into from
Dec 11, 2016

Conversation

searls
Copy link
Member

@searls searls commented Dec 10, 2016 •
edited
Loading

  • Make native ES class replacement work (node 6 & up
  • Make babel'd ES class replacement work
  • Make default export class work (requires changing function bag behavior)
  • Make func bag improvements work for property replacement as well as module replacement
  • fix 0.10 failures
  • make it not a mess
  • add explicit tests
  • test against node < 6
  • document it

Resolves #119
Resolves #157

@searls searls mentioned this pull request Dec 10, 2016
Closed
@searls searls merged commit 6a47560 into master Dec 11, 2016
@searls
Copy link
Member Author

searls commented Dec 11, 2016

Landed in 1.1.0

@searls searls deleted the class-replacement branch December 11, 2016 01:51
@LandonSchropp LandonSchropp mentioned this pull request Dec 13, 2016
Closed
@kealthou kealthou mentioned this pull request Apr 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mocking a Class td.replace doesn't properly detect ES6 classes
2 participants
@searls @monkbroc