Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace constructors with constructors #193

Merged
merged 11 commits into from
Mar 6, 2017
Merged

Replace constructors with constructors #193

merged 11 commits into from
Mar 6, 2017

Commits on Mar 3, 2017

  1. WIP ~ make breaking change to constructors

    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    a11fdae View commit details
    Browse the repository at this point in the history

  2. woah, stubbing/verifying constructor "just worked"

    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    510fc3a View commit details
    Browse the repository at this point in the history

  3. unleash the broken tests

    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    d12c5d5 View commit details
    Browse the repository at this point in the history

  4. fix constructor changes in verify test

    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    3b960b7 View commit details
    Browse the repository at this point in the history

  5. Get tests passing 

    * Whack newly-unnecessary wrappers "yay!"
* Fixes unit tests under browsers & node
    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    7462729 View commit details
    Browse the repository at this point in the history

  6. fix example tests 

    * webpack is still failing
    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    bc74cd4 View commit details
    Browse the repository at this point in the history

  7. yay! new webpack fixed this stupid fork bug. 

    My conservative "wait a year because debugging inside the webpack 
codebase sounds terrible" strategy pays off yet again!
    @searls
    searls committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    ea06fbc View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2017

  1. Fix build with rogue & instead of && 

    This backgrounding webpack which is definitely NOT what we want
    @searls
    searls committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    eddc506 View commit details
    Browse the repository at this point in the history

  2. Fix not-guaranteed-to-be-defined td global 

    This only showed up in 1 of our 4 or 5 example projects
(webpack) and it wasn't obvious that the root cause was 
the source listing referencing td.

How the heck do I test for this global not to be set when
all the tests set it?? Ughhhhhhh
    @searls
    searls committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    18129f5 View commit details
    Browse the repository at this point in the history

  3. update docs

    @searls
    searls committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    996dee5 View commit details
    Browse the repository at this point in the history

  4. downgrade webpack while 0.10/0.12 are still supported

    @searls
    searls committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    3cd4caf View commit details
    Browse the repository at this point in the history