Rework test build #211
Merged
Rework test build #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I sorta can't believe this actually worked in one shot.
when-test had to change because mocha 3 blows up if a method returns a then-able and also uses callbacks
searls
force-pushed
the
browserify-tests
branch
from
ec1e409
to
8571f40
Compare
searls
force-pushed
the
browserify-tests
branch
from
8571f40
to
5823296
Compare
This kills our istanbul config btw, oops
this will blow up in node 4 b/c we cannot override the js:babel compiler how can i get this to run only for the node 6 build?
|
heads up @jacobthemyth, this actually worked! Took a ton of fiddling, but the build is now against the full browserified bundle |
|
Nice! I'm not sure how much I helped, but definitely happy to see it working :)
… On Mar 18, 2017, at 11:32 AM, Justin Searls ***@***.***> wrote:
heads up @jacobthemyth, this actually worked! Took a ton of fiddling, but the build is now against the full browserified bundle
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lot of work needed to whip the test build into shape, however we plan to do that (ES6, teenytest, etc).
requirecouldn't be used, but getting a browserify build solves this