Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify testing #22

Merged
merged 7 commits into from
Sep 13, 2015
Merged

Browserify testing #22

merged 7 commits into from
Sep 13, 2015

Conversation

searls
Copy link
Member

@searls searls commented Sep 13, 2015

Adds tests of the browser stuff. Makes a million and a half changes.

Will probably rankle @jasonkarns who will insist on cleaning things up.

Only thing I wanted that I didn't get was a printed version name in the browserify bundle

* make global.testdouble, global.lodash
* requireSubject no longer calls require, just
reduces on the testdouble global (only required a 
change to one line of all the test code), all passing
Does a bunch of stuff in one commit b/c :shipit:

* Does browser testing with mocha-given b/c
mocha-gwt doesn't distribute a browser bundle and
YOLO
* Adds as custom testem view template b/c that's the
only feasible way to do a custom mocha UI.
* In CI, runs the node-mocha tests outside testem
b/c the testem custom launcher will often exit code
zero even when it fails (yikes)
* set up custom watch files on the coffee-script
directories we care about
* Updates travis
searls added a commit that referenced this pull request Sep 13, 2015
@searls searls merged commit 9ddfff1 into master Sep 13, 2015
@searls searls deleted the browserify-testing branch September 13, 2015 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants