Stop extending types when replacing constructors #254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
I made a mistake in td 2.0 and it took too long to catch. Mea culpa. I feel bad.
What went wrong
I've decided after fighting various babel shenanigans to give up on trying to create test double constructors that will pass instanceof checks. The reality is that the ES Class spec buttons up any cuteness I'd been able to previously get away with, namely
instanceof
check of a class without extending itnew
, which violates a runtime check of the ES class spec.New behavior
Going forward,
td.replace()
on constructors will not extend the original type, and will instead copy over attribute values and imitate functions. The previous behavior will be hidden behind a global configuration option calledtd.config({extendWhenReplacingConstructors: false})
for the handful of folks who really want their test doubles to passinstanceof
checks (which I suspect is a small minority, given how sparingly theinstanceof
keyword is typically used).Resolves #242