Fix example tests #303
Merged
Fix example tests #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json for each of node, babel and webpack examples now uses relative path as version spec. yarn handles this by simply not installing testdouble into node_modules so it gets resolved by ancestor hierarchy. npm5 handles this by symlinking from node_modules to ancestor directory. In both cases, testdouble dep is resolved as the live, in-repo module.
There's no need to cd back to original directory because the package script is executed within a subshell. Once the script completes, final working directory is still unchanged
jasonkarns
force-pushed
the
fix-examples
branch
from
6828971
to
b8cdc2c
Compare
|
Looks like the lineman example is using a bundled build of testdouble? Unsure how that gets updated to point to latest builds... |
|
IIRC, the lineman build depends on running browserify compilation and then symlinking to dist/testdouble.js |
|
👍 didn't catch the symlink earlier. In that case, this PR should be good to go I think |
|
Thanks Jason! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #302
package.json for each of node, babel and webpack examples now uses relative path as version spec. yarn handles this by simply not installing testdouble into node_modules so it gets resolved by ancestor hierarchy. npm5 handles this by symlinking from node_modules to ancestor directory.
In both cases, testdouble dep is resolved as the live, in-repo module.