-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try out TypeScript #343
Merged
Merged
Try out TypeScript #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, TS tacks on a ".default" to 3rd party imports whereas babel wasn't doing this.
Remove an npm script & generated dir while we're at it
to include my test directory in what's compiled by tsc. Or do I, maybe? Instead of using ts-node/require? This seems not good.
2. [... lol] is compiled differently by babel & TS
I'm deciding to merge for two reasons:
In particular,
And here's the same command compiled under typescript:
For a better than 4x speedup in walltime for my test feedback loop, I'd gladly switch compilers even if I never write a single '.ts' file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress
npm test
passBlockers
ts-node
for its require.extensions hook to run our tests, but it appears to blow up on Node v4 which is failing the build. (Fix: the explosion was caused by me targeting es2015 instead of es5)