Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken npm install on Windows #345

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Conversation

duluca
Copy link
Contributor

@duluca duluca commented Feb 26, 2018

Current Behavior

npm install fails on Windows, because rm -rf doesn't exist. When that issue is resolved, dist/testdouble.js fails to generated, because Windows can't parse $npm_package_config_build_file.

Expected Behavior

npm install works on Windws.

Changes made

[x] Replaced rm -rf with rimraf on the clean script
[x] Added cross-conf-env to compile:browser step, so $npm_package_config_build_file is interpreted correctly

Future suggestion

  • version:write and version:changelog may also benefit from cross-conf-env

@searls
Copy link
Member

searls commented Feb 26, 2018

Would you mind re-working this without the changes to the indentation/formatting of the package.json?

@duluca
Copy link
Contributor Author

duluca commented Feb 26, 2018

@searls Didn't mean to change the formatting, rolled it back

@searls
Copy link
Member

searls commented Feb 26, 2018

Thanks! I think the same applies to the other PR you started. I hope to find some spare time to look at it soon, but if you start chipping away some of the tsc errors, that'd be great too.

@searls searls merged commit 2a73790 into testdouble:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants