Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Circle CI config to master #349

Merged
merged 19 commits into from
Feb 27, 2018
Merged

Merge Circle CI config to master #349

merged 19 commits into from
Feb 27, 2018

Conversation

searls
Copy link
Member

@searls searls commented Feb 27, 2018

  • rebase if needed
  • see travis still passing
  • see circle passing

@zzak
Copy link
Contributor

zzak commented Feb 27, 2018

Thanks for moving on this!

I have no idea why the cover command fails on node 4 and 6.

I'd also like to re-enable npm caching once it's fixed, which should save a little more time.

Please let me know if you have any questions about our stuff!

@searls
Copy link
Member Author

searls commented Feb 27, 2018

Hey @zzak what did you mean by fixing caching once fixed? Now that the build is green can you re-enable caching or did you mean to say the feature itself was broken?

@searls
Copy link
Member Author

searls commented Feb 27, 2018

@zzak since it's probably your 2am right now, I'm just going to merge what we have since it's definitely faster than Travis has been and I'd like to try it out for a couple weeks. Please feel free to try a subsequent PR for module caching

@searls searls merged commit 945b8ed into master Feb 27, 2018
@searls searls deleted the circle-ci branch February 27, 2018 18:45
@zzak
Copy link
Contributor

zzak commented Feb 27, 2018

@searls I turned it off here to make sure that wasn't the reason it failed:
1a7f0d6

@searls
Copy link
Member Author

searls commented Feb 27, 2018 via email

@zzak
Copy link
Contributor

zzak commented Feb 27, 2018

@searls Looks like that wasn't a clean commit because it changed npm commands, I will send a new patch.

@zzak zzak mentioned this pull request Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants