-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Circle CI config to master #349
Conversation
searls
commented
Feb 27, 2018
•
edited
Loading
edited
- rebase if needed
- see travis still passing
- see circle passing
Merge in Circle CI config
Thanks for moving on this! I have no idea why the cover command fails on node 4 and 6. I'd also like to re-enable npm caching once it's fixed, which should save a little more time. Please let me know if you have any questions about our stuff! |
(Code Climate can only handle one coverage stat per git ref)
Hey @zzak what did you mean by fixing caching once fixed? Now that the build is green can you re-enable caching or did you mean to say the feature itself was broken? |
@zzak since it's probably your 2am right now, I'm just going to merge what we have since it's definitely faster than Travis has been and I'd like to try it out for a couple weeks. Please feel free to try a subsequent PR for module caching |
Revert attempted here https://github.com/testdouble/testdouble.js/blob/master/.circleci/config.yml does that look right?
…
|
@searls Looks like that wasn't a clean commit because it changed |