Implement ES2015 proxy doubles #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we add proxy objects it's going to be too damn awkward otherwise What is a "test double"? is it a function or an object? the correct answer should be it could be either, so let's not pretend one is the 'real' test double and the other is just an object on it or a function of it
|
To run tests in firefox for TDD: |
'then' was really problematic, because Mocha itself will test for promisey-ness. The only workable thing was to allow users to configure which methods are excluded by a proxy double and to default 'then' among them Is this a mocha specific hack that will throw users off? Time will tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create()is already ambiguous and stood to become even moresoResolves #39