Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #423

Merged
merged 5 commits into from
Jul 16, 2019
Merged

Update dependencies #423

merged 5 commits into from
Jul 16, 2019

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Jul 15, 2019

I only did superficial testing, ran the build and test and ran our project's test suite against this version of testdouble. There are two major version updates:

  1. nyc: Tested npm run cover and everything seems to still work
  2. standard: Version 13.0.0 dropped support for Node 6 but is supposed to silently pass for compatibility reasons. Not sure if this is a blocker for upgrading or not.

@lumaxis
Copy link
Contributor Author

lumaxis commented Jul 15, 2019

Looks like the build fails with a lint issue:

standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/lukas/Work/oss/testdouble.js/src/object/proxy.ts:33:15: Do not access Object.prototype method 'hasOwnProperty' from target object.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! testdouble@3.12.1 style:ts: `standard --fix --parser @typescript-eslint/parser --plugin @typescript-eslint/eslint-plugin "**/*.ts"`
npm ERR! Exit status 1

I'll see if I can fix that tomorrow.

@searls searls merged commit cacc21f into testdouble:master Jul 16, 2019
@searls
Copy link
Member

searls commented Jul 16, 2019

Landed in 3.12.2

@lumaxis
Copy link
Contributor Author

lumaxis commented Jul 16, 2019

@searls Awesome, thanks for pushing this over the finish line! 🙏🏼

@lumaxis lumaxis deleted the update-dependencies branch July 16, 2019 14:59
@searls
Copy link
Member

searls commented Jul 16, 2019

Thanks for the push <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants