-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better docs #49
Better docs #49
Conversation
I like how that reads! Just a small thought, one of the beauties of delegating to collaborators is that the method under test does not need to care for implementation details of the invoked methods. So in practice I would not say |
Thanks for the comment. I might make that change. In reality, a lot of times, as developers we're tasked with some implementation details baked into the requirements we're handed (especially relating to protocols and the interaction of our work product with other technologies). For that reason, POSTing in an example like this isn't necessarily an implementation detail of the thing under test, since it affects extrinsic behavior. In cases like the above, I actually value a little bit of technical telegraphing in the test, because a vague business-ey description doesn't add much. (And to anticipate one reply, if an extrinsic change were ever made to this dependency such that it'd use a websocket instead of a POST, my workflow with test doubles would be to delete the dependency and its entire sub-tree of units, so I'm not too worried about comment rot) |
Thanks for the elaboration! I definately agree on some technical telegraphing (love the expression 🎉). You'd likely also write some tests for the |
of docs/3-howto-getting-started.md
BOOM. Finally done. |
Start the long task of writing better docs.