Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename src and scripts #61

Merged
merged 3 commits into from
Dec 4, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ npm-debug.log*
/node_modules

/generated
/lib
3 changes: 2 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
# this file is necessary so that npm doesn't use .gitignore;
# gitignore ignores generated/ which *must* be included in the package.
# gitignore ignores lib/ which *must* be included in the package.

4 changes: 1 addition & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@ language: node_js
node_js:
- "4.1"
- "0.12"
script:
- npm run test:ci
- npm run test:examples
script: npm run test:ci
2 changes: 1 addition & 1 deletion docs/6-verifying-invocations.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Error: Unsatisfied verification on test double `quack`.

But was actually called:
- called with `("QUACK")`.
at Object.module.exports [as verify] (/Users/justin/code/testdouble/testdouble.js/generated/verify.js:22:15)
at Object.module.exports [as verify] (/Users/justin/code/testdouble/testdouble.js/lib/verify.js:22:15)
```

As you can see, the expected arguments of the failed verification are pritned
Expand Down
21 changes: 10 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,29 @@
"email": "justin@testdouble.com",
"url": "http://testdouble.com"
},
"main": "generated/testdouble.js",
"main": "lib/testdouble.js",
"config": {
"build_file": "dist/testdouble.js",
"mocha_reporter": "spec"
},
"scripts": {
"clean": "rm -rf generated dist && git checkout -- dist",
"clean": "rm -rf generated dist lib && git checkout -- dist",
"start": "testem",
"compile": "coffee --output generated --compile lib",
"compile:tests": "coffee --output generated/test --compile test",
"compile:node": "coffee --output lib --compile src",
"compile:test": "coffee --output generated/test --compile test",
"compile:browser": "browserify . --standalone testdouble --outfile $npm_package_config_build_file --ignore 'quibble'",
"compile": "npm run compile:node && npm run compile:test && npm run compile:browser",
"test": "mocha --ui mocha-given --reporter $npm_package_config_mocha_reporter --compilers coffee:coffee-script --recursive test/node-helper.coffee test/lib",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just point mocha at the generated/test and drop the coffeeify transform? (assuming pretest does compile:node/compile:test) Would eliminate the differing of coffee compilers between what's tested and what's distributed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea but I'm not going to have any time for tdjs until after the holidays; could you please create an issue?

"test:ci": "npm run test --testdouble:mocha_reporter=tap && testem ci",
"test:examples": "cd examples/node && npm i && npm test && cd ../..",
"test:example": "cd examples/node && npm i && npm test && cd ../..",
"test:ci": "npm run test --testdouble:mocha_reporter=tap && testem ci && npm run test:example",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we should look at making test:ci only be testem ci (ie, including the test and test:example in testem proper)

"test:debug": "npm test -- --debug-brk",
"prebuild": "npm run compile",
"build": "browserify . --standalone testdouble --outfile $npm_package_config_build_file --ignore 'quibble'",
"audit:disc": "npm run build -- --full-paths && discify $npm_package_config_build_file --open",
"preversion": "git pull --rebase && npm run test:ci",
"version": "npm run build && git add dist",
"version": "npm run compile && git add dist",
"postversion": "git push && git push --tags && npm publish",
"prepublish": "npm run compile"
},
"browser": {
"./generated/replace.js": "./generated/replace.browser.js"
"./lib/replace.js": "./lib/replace.browser.js"
},
"browserify": {
"transform": [
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions testem.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ module.exports = {

framework: 'mocha+chai',

before_tests: "npm run compile:tests && npm run build",
before_tests: "npm run compile",
//might want to add this if you do a lot of file-delete/add churn; faster w/o.
//after_tests: "npm run clean",

Expand All @@ -35,7 +35,7 @@ module.exports = {
],

watch_files: [
"lib/**/*",
"src/**/*",
"test/**/*"
]
};