Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose server to middleware #1052

Open
alexander-alvarez opened this issue Jan 5, 2017 · 3 comments · May be fixed by #1053
Open

Expose server to middleware #1052

alexander-alvarez opened this issue Jan 5, 2017 · 3 comments · May be fixed by #1053
Labels

Comments

@alexander-alvarez
Copy link

alexander-alvarez commented Jan 5, 2017

So that we can proxy websockets via upgrade (like this) in testem middleware.

Would we be against passing this.server to the injectMiddlewareFunction ?

@johanneswuerbach
Copy link
Member

johanneswuerbach commented Jan 5, 2017

No, sounds good to me 👍

@NullVoxPopuli
Copy link

This is likely required for what I'm trying to do over here: NullVoxPopuli/ember-addon-test#1
(and testem support to Vite -- I already have qunit running).

The main issue right now I see is that testem expects itself to be the running server -- which I don't want in this case.

@johanneswuerbach
Copy link
Member

I don't really use testem actively in my day to day anymore, but would definitely be willing to support a PR implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants