Extending middleware functionality, and documenting in config_file #1053
Conversation
|
Could you add a test here https://github.com/testem/testem/blob/master/tests/server_tests.js to ensure we don't regress this feature in the future? Otherwise this looks good 👍 |
|
Friendly ping @alexander-alvarez :-) |
|
👍 I'll get to it this long weekend |
|
@johanneswuerbach can you check that this is testing in the right way? |
tests/server_tests.js
Outdated
| after(function(done) { | ||
| server.stop(function() { | ||
| done(); | ||
| }); |
There was a problem hiding this comment.
Could you move this after code into the test itself? Otherwise if might be confusing when another test is added here and after kills the server for both.
tests/server_tests.js
Outdated
| }); | ||
| server = new Server(config); | ||
| server.once('server-start', function() { | ||
| done(); |
There was a problem hiding this comment.
Looks like this test uses done twice?
There was a problem hiding this comment.
modeled it after the auto port assignment, should I not do that?
There was a problem hiding this comment.
Yes, but the done function should generally only be called once in a test. In your test you call it twice, ones after the server is booted and once during the middleware creation. I guess the middleware one should be dropped. Could you make sure that it no longer passes when you stop passing app in the code?
@johanneswuerbach not sure what you meant |
tests/server_tests.js
Outdated
| config = new Config('dev', { | ||
| port: 0, | ||
| cwd: 'tests', | ||
| middlewear: [ |
There was a problem hiding this comment.
This property seems to contain a typo.
|
Would love to see some progress on this -- I'm trying to integrate testem with Vite, and it'd be a bit easier if I didn't need to figure out how to coordinate two servers 🙃 |
Closes #1052