Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP results should still respect exit status code #527

Closed
jasonkarns opened this issue Mar 31, 2015 · 2 comments
Closed

TAP results should still respect exit status code #527

jasonkarns opened this issue Mar 31, 2015 · 2 comments
Labels

Comments

@jasonkarns
Copy link
Contributor

The TAP result parser correctly shows the pass/total test results in the tab. However, if there is an error in the process that isn't caught by the testing framework (say, outside of a test or in an after hook or similar), then it's possible for the process to exit with a non-zero status code. In such a scenario, the tab is rendered Green since the TAP results reported successful, even though the process errored.

I think that the exit status code should be respected, even when given TAP output. launcher 20/20 (or whatever) in the tab name is still fine, but it should be colored red if exit status code is non-zero.

fd71e7aa-c98f-11e4-86e0-2d19e36f6d59

@jasonkarns
Copy link
Contributor Author

I think this is related to #131

@johanneswuerbach
Copy link
Member

This should be resolved in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants