Fix Mocha's duplicate error messages on failure #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha fires a "fail" event for test failures and hook failures, but fires a "test end" event only for tests. Since we want to handle hook failures as well, the "fail" event was accounted for in testem#1045. But this caused error messages to be logged twice since the handler code was also firing for the corresonding "test end" events that are fired for every "fail" event. This commit removes the handler code from the "test end" event for failed tests so that it logs errors only once.
|
Checking now |
|
@getsnoopy It appears that the use-case where 👍 |
|
👍 @johanneswuerbach we should be good to merge |
|
Sorry, thanks for the bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha fires a "fail" event for test failures and hook failures, but
fires a "test end" event only for tests. Since we want to handle
hook failures as well, the "fail" event was accounted for in #1045.
But this caused error messages to be logged twice since the handler
code was also firing for the corresonding "test end" events that
are fired for every "fail" event. This commit removes the handler
code from the "test end" event for failed tests so that it logs
errors only once.