[BugFix] On browserRelogin, clear timeouts if socket is not null & log.warn instead of error for reconnection from unknown browser #1386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On browserRelogin event, there are times where the socket is not null. When we call tryAttach() on an existing socket, eventListeners attached from
tryAttach()
will be duplicated.When there is an unknown browser reconnecting, app.js will throw an error and the run will fail. This could happen if a previous run's browser for some reason did not terminate.
Solutions:
On browserRelogin, clear timeouts if socket is not null. This will prevent socket events duplication.
log.warn
instead of throwing an error for reconnection from unknown browser. This way, the current run won't be punished for dangling browsers from previous runs.