Fix: unwrap event & fix groups typo.

[laurentsenta]

When testing with the latest testground, the example would end in "failed" state despite a successful run. When I looked at the JSON, it looked like the payload for events are malformed and they are not registered by the testground runner.

This changes the payload from:

{"event":{"success_event":{"groups":"single"}}}

to:

{"success_event":{"group":"single"}}

[mxinden]

Great catch @laurentsenta!

For the record: https://github.com/testground/sdk-go/blob/d78f61eccaa37b0d941f98650bce5dbb8fd7b7f1/runtime/runenv_events.go#L68-L70

[mxinden]

Mind adding a changelog entry?

https://github.com/testground/sdk-rust/blob/master/CHANGELOG.md

Also is there any way to make the CI fail on this error, to prevent regressions in the future?

sdk-rust/.github/workflows/ci.yml

Lines 106 to 114 in 5c50ba4

	- name: Run testground plan (sdk-rust)
	run: |
	testground run single \
	--plan=sdk-rust \
	--testcase=example \
	--builder=docker:generic \
	--runner=local:docker \
	--instances=1 \
	--wait

[laurentsenta]

(changelog updated and follow-up issue created in pl-strflt/ipdx#20)

[mxinden]

Mhhh, with current master I get:

May  4 15:37:32.920913  INFO    run finished successfully       {"run_id": "c9p9qe4oi0mko9e6i0l0", "plan": "sdk-rust", "case": "example", "runner": "local:docker", "instances": 1}

with this branch I get:

May  4 15:33:49.226364  WARN    run finished in error   {"run_id": "c9p9pjkoi0mko9e6i0kg", "plan": "sdk-rust", "case": "example", "runner": "local:docker", "instances": 1, "error": "1 nodes failed"}  

Testground version:

$ testground  version  
Testground
Git commit: 6ae5c95b

Still need to debug this further.

[laurentsenta]

Could you run the test a couple of times and share the full log when this branch fails? (I couldn't reproduce),

run finished successfully is expected in both cases,

That's the dashboard result we should care about:
if you look at http://localhost:8042 I suspect the test run on master will have status=❌
and the test in this branch will pass most of the time.

[laurentsenta]

@mxinden fwiw running on the CI (with the other patch that captures failures correctly):

master fails consistently:
https://github.com/laurentsenta/sdk-rust/actions/runs/2301527886
(top right, there is a dropdown with all 4 failed runs)

this branch passes:
https://github.com/laurentsenta/sdk-rust/actions/runs/2301540056
(same dropdown top right, "most" runs pass)

[mxinden]

Not able to reproduce the failures I have been seeing. Sorry for the noise.

Tested once again locally. Both log output and dashboard report run with this branch as success.

Will merge here. Thanks @laurentsenta!