Rename methods

As they are related to queue dispatcher, we rename
some methods in order to clarify.

include/ert/http2comm/Http2Server.hpp

@@ -71,7 +71,7 @@ class Http2Server
     std::string api_version_{};
     boost::asio::io_service *timers_io_service_;
     ert::queuedispatcher::QueueDispatcher *queue_dispatcher_;
-    int max_queue_dispatcher_size_{};
+    int queue_dispatcher_max_size_{};
 
     nghttp2::asio_http2::server::request_cb handler();
 
@@ -115,11 +115,11 @@ class Http2Server
     *  @param workerThreads number of worker threads.
     *  @param maxWorkerThreads number of maximum worker threads which internal processing could grow to. Defaults to '0' which means that maximum equals to provided worker threads.
     *  @param timerIoService Optional io service to manage response delays
-    *  @param maxQueueDispatcherSize This library implements a simple congestion control algorithm which will indicate congestion status when queue dispatcher (when used) has no
+    *  @param queueDispatcherMaxSize This library implements a simple congestion control algorithm which will indicate congestion status when queue dispatcher (when used) has no
     *  idle consumer threads, and queue dispatcher size is over this value. Defaults to -1 which means 'no limit' to grow the queue (this probably implies response time degradation).
     *  So, to enable the described congestion control algorithm, provide a non-negative value.
     */
-    Http2Server(const std::string& name, size_t workerThreads, size_t maxWorkerThreads = 0, boost::asio::io_service *timerIoService = nullptr, int maxQueueDispatcherSize = -1 /* no limit */);
+    Http2Server(const std::string& name, size_t workerThreads, size_t maxWorkerThreads = 0, boost::asio::io_service *timerIoService = nullptr, int queueDispatcherMaxSize = -1 /* no limit */);
     virtual ~Http2Server();
 
     // setters
@@ -128,7 +128,12 @@ class Http2Server
     /**
     * Gets the queue dispatcher busy threads
     */
-    int busyThreads() const;
+    int getQueueDispatcherBusyThreads() const;
+
+    /**
+    * Gets the queue dispatcher number of scheduled threads
+    */
+    int getQueueDispacherThreads() const;
 
     /**
     * Gets the queue dispatcher size
@@ -143,7 +148,7 @@ class Http2Server
     * queue dispatcher has no idle consumer threads and also, queue size is over this specific
     * value.
     */
-    int getMaxQueueDispacherSize() const;
+    int getQueueDispacherMaxSize() const;
 
     /**
     * Enable metrics

src/Http2Server.cpp

@@ -58,22 +58,26 @@ namespace ert
 namespace http2comm
 {
 
-Http2Server::Http2Server(const std::string& name, size_t workerThreads, size_t maxWorkerThreads, boost::asio::io_service *timersIoService, int maxQueueDispatcherSize):
-    name_(name), timers_io_service_(timersIoService), reception_id_(0), maximum_request_body_size_(0), max_queue_dispatcher_size_(maxQueueDispatcherSize) {
+Http2Server::Http2Server(const std::string& name, size_t workerThreads, size_t maxWorkerThreads, boost::asio::io_service *timersIoService, int queueDispatcherMaxSize):
+    name_(name), timers_io_service_(timersIoService), reception_id_(0), maximum_request_body_size_(0), queue_dispatcher_max_size_(queueDispatcherMaxSize) {
 
     queue_dispatcher_ = (workerThreads > 1) ? new ert::queuedispatcher::QueueDispatcher(name + "_queueDispatcher", workerThreads, maxWorkerThreads) : nullptr;
 }
 
-int Http2Server::busyThreads() const {
+int Http2Server::getQueueDispatcherBusyThreads() const {
     return (queue_dispatcher_ ? queue_dispatcher_->getBusyThreads():0);
 }
 
+int Http2Server::getQueueDispacherThreads() const {
+    return (queue_dispatcher_ ? queue_dispatcher_->getSize():0);
+}
+
 int Http2Server::getQueueDispacherSize() const {
     return (queue_dispatcher_ ? queue_dispatcher_->getSize():0);
 }
 
-int Http2Server::getMaxQueueDispacherSize() const {
-    return max_queue_dispatcher_size_;
+int Http2Server::getQueueDispacherMaxSize() const {
+    return queue_dispatcher_max_size_;
 }
 
 void Http2Server::enableMetrics(ert::metrics::Metrics *metrics,

src/Stream.cpp

@@ -67,7 +67,7 @@ void Stream::appendData(const uint8_t* data, std::size_t len) {
 }
 
 void Stream::process(bool busyConsumers, int queueSize) {
-    reception(server_->getMaxQueueDispacherSize() >= 0 /* congestion control enabled */ && busyConsumers && queueSize > server_->getMaxQueueDispacherSize());
+    reception(server_->getQueueDispacherMaxSize() >= 0 /* congestion control enabled */ && busyConsumers && queueSize > server_->getQueueDispacherMaxSize());
     commit();
 }