Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed id="add-contact" breaks e2e tests downstream #14

Closed
cnishina opened this issue Sep 20, 2017 · 1 comment · Fixed by #15
Closed

Removed id="add-contact" breaks e2e tests downstream #14

cnishina opened this issue Sep 20, 2017 · 1 comment · Fixed by #15

Comments

@cnishina
Copy link
Member

cnishina commented Sep 20, 2017 •
edited

This commit is breaking my tests 87c8e29 downstream. Should have Protractor tests included in CI
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
26721cc 
- add back `id="add-contact"` to the contact-list template
- add circle ci integration

closes testing-angular-applications#14
@cnishina cnishina mentioned this issue Sep 20, 2017
Merged
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
c4c6b3e 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
7e78eac 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
259c7a0 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
22ac590 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
c257950 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
b72a4ba 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
35bd554 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
d6f0878 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
9f22c05 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests
- add circleci shield to readme file

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 20, 2017
@cnishina
add protractor tests to contact-app-starter
6367383 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests
- add circleci shield to readme file

closes testing-angular-applications#14
@cnishina cnishina changed the title Removed id="add-contact" Removed id="add-contact" breaks e2e tests downstream Sep 20, 2017
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 22, 2017
@cnishina
add protractor tests to contact-app-starter
9f4cddb 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests
- add circleci shield to readme file

closes testing-angular-applications#14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Sep 22, 2017
@cnishina
add protractor tests to contact-app-starter
993b69b 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests
- add circleci shield to readme file

closes testing-angular-applications#14
@jesselpalmer
Copy link
Member

sorry about that. i should have asked you to take a look at it before i made that change.

jesselpalmer pushed a commit that referenced this issue Sep 22, 2017
@cnishina @jesselpalmer
add protractor tests to contact-app-starter
9248631 
- add back `id="add-contact"` to the contact-list template
- add Protractor tests: contact list, new contact, and with page object
  tests
- add circle ci integration
- update .gitignore to not save output/ directory for junit tests
- add circleci shield to readme file

closes #14
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Oct 28, 2017
@cnishina
migration - chapter08 (testing-angular-applications#1)
78b5ae6 
Previous commit messages from chapter-8-code:

* test(simple): write first test to find the contact list title (testing-angular-applications#1)

- Set up repo similar to the angular-cli e2e directory structure.
  Protractor.conf.js, tsconf.json, and tslint.json match the
  angular-cli files.
- Update dependencies and devDependencies to run Protractor test.
- Add scripts to package.json to transpile typescript files,
  download chromedriver binary, and run the protractor test.
- Use a page object called contact-list.po.
- Write a test using the page object. the test verifies that the
  title is not null and matches the title.

* test(simple): create a protractor config for the simple test (testing-angular-applications#2)

- use the protractor.conf.js as the base configuration
- edit the specs array to run only the first test

* test(first-test): create a barebones test (testing-angular-applications#3)

The first test is runnable with `npm run e2e test-8-0.conf.js`.

Running the first test command should launch the `pree2e` command.
This will launch webdriver-manager to download the chromedriver
binary.

Protractor will then run the `e2e/test-8-0.e2e-spec.ts` file and
navigate to https://angularjs.org and check to see if the current url
matches.

* test(8.1): example for section 8.1 (testing-angular-applications#4)

* test(8.2): example for section 8.2 (testing-angular-applications#5)

Test adding a new contact by:
- clicking the add button
- filling out the contact form
- clicking the submit button

Covers:
- finding elements with  by.id and by.buttonText
- interacting with elements by clicking and sending keys
- browser alerts and dismissing them
- waiting for expected conditions

* try(circleci): add circleci 2.0 (testing-angular-applications#9)

Use circleci 2.0 with directConnect. This does not take advantage of
docker-compose but this is a good starting point.

* test(8.1 and 8.2): update for jenkins (testing-angular-applications#12)

* test(element): a collection of element methods (testing-angular-applications#13)

* test(tables): examples for `by` and `element` methods (testing-angular-applications#14)

* test(element.all): examples to filter, map, and reduce (testing-angular-applications#15)

* test(pageobjects): add page objects to test-8-4 (testing-angular-applications#16)

* fix package.json details (testing-angular-applications#17)

* update readme to include circle ci build shield (testing-angular-applications#18)

* improve tables to have more examples and comments (testing-angular-applications#19)

* change the alert message dismiss to modal click (testing-angular-applications#20)

* after dismissing the modal, use expected conditions to check that it is not there (testing-angular-applications#21)

* fix tests for ElementArrayFinder and TypeScript errors (testing-angular-applications#22)

* rename files to more meaningful names. (testing-angular-applications#23)

- rename *.e2e-spec.ts files to more meaningful names
- rename protractor configuration files to more meaningful names
- add clang formatting and format everything
- update circleci to run all test suites and enforce formatting

* add linter checks (testing-angular-applications#25)

* separate out add contact into two files and use globbing in conf (testing-angular-applications#26)

* remove extra describes from the add contact tests (testing-angular-applications#27)

* clean up page objects (testing-angular-applications#28)

* use onPrepare method over beforeLaunch (testing-angular-applications#29)

* migration - move chapter 8 code to chapter08/
cnishina added a commit to cnishina/testing-angular-applications that referenced this issue Oct 28, 2017
@cnishina
migration - chapter10 (testing-angular-applications#3)
819249b 
Previous commit messages from chapter-10-code:

* Initial commit

* initial commit with dependencies (testing-angular-applications#1)

* test listing for capabilities (testing-angular-applications#2)

* multicapabilities example

- broken. might need to fix the Protractor

* moving files around so package.json are separate (testing-angular-applications#3)

* plugins example using junit style reports (testing-angular-applications#5)

* environment options (testing-angular-applications#7)

* add headless test to capabilities (testing-angular-applications#8)

* set the default browser name to chrome if the BROWSER_NAME is not provided (testing-angular-applications#9)

* refactor tests (testing-angular-applications#10)

* add test for jenkins based on IS_JENKINS (testing-angular-applications#11)

* circle ci tests (testing-angular-applications#12)

* add formatting to chapter 10 code (testing-angular-applications#13)

* fix multicapabilities test (testing-angular-applications#14)

- since firefox requires (possibly) a selenium-webdriver depedency
  update in protractor, we'll use safari and chrome
- chrome can still be used to show off multicapabilities by using
  chrome twice
- update circle ci test to test everything

* rename files from .spec.ts to .e2e-spec.ts (testing-angular-applications#15)

* cleanup protractor configuration files (testing-angular-applications#16)

- Run ts-node onPrepare instead of beforeLaunch. this will work on
  multicapabilities
- Set plugin example using the `plugins` configuration setting
- Use `let` over `var` in protractor configuration file.

* clean up protractor config spec to use consistent file globbing (testing-angular-applications#17)

* remove boolean comparison to protractor config (testing-angular-applications#18)

* Working on screenshot test

* Take screenshots on test failure.

* Make golden image smaller.

* Debugging and screenshot example.

* Moving screenshot tests to a subdir

* Update golden screenshot, fix tests

* Clean up debugging example.

* Added detail to README.md

* Rename config file

* Fix debugging script

* run formatting to fix the circle ci tests (testing-angular-applications#19)

- add back the package.json for formatting
- remove dev dependencies from main directory package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add protractor tests to contact-app-starter cnishina/testing-angular-applications
2 participants
@jesselpalmer @cnishina