Add package name to setup.py #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtcollins
reviewed
Aug 13, 2018
| @@ -2,5 +2,6 @@ | |||
| import setuptools | |||
|
|
|||
| setuptools.setup( | |||
| name='mock', | |||
There was a problem hiding this comment.
Could you explain why this is needed / desirable? I don't like the duplication of metadata that this creates.
There was a problem hiding this comment.
This keyword is required by Buildroot's script scanpypi in order to automatically add Python package to Buildroot's tree. At the point of invocation setup metadata won't be expanded though pbr, so 'name' is missing.
So basically my PR should remove 'name' from setup.cfg and add it to setup.py.
There was a problem hiding this comment.
Well pip manages to figure it out just fine - I think you've got a bug in scanpypi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.