Fallback to reading one-byte-at-a-time if select.select fails #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes select.select() silently swallow possibly valid errors on any platform, including Linux. Could we instead check if the platform is windows and not even try to invoke select.select in that case? |
|
Sure. |
select.select does not work on file descriptors on Windows, causing subunit to fail. Closes-Bug: #1668233
|
Hello, I've updated the PR. |
|
It'd be nice to have a unit test, but I understand it's not going to be particularly meaningful (and Travis CI doesn't support targeting Windows). So, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select.select does not work on file descriptors on Windows, causing subunit to fail.
Closes-Bug: #1668233