Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: provider is undefined #25

Closed
timdeschryver opened this issue Jun 14, 2019 · 1 comment · Fixed by #26
Closed

bug: provider is undefined #25

timdeschryver opened this issue Jun 14, 2019 · 1 comment · Fixed by #26
Labels
bug Something isn't working released

Comments

@timdeschryver
Copy link
Member

With the change in #19 the global providers are undefined.

Repro: the tests at https://github.com/testing-library/angular-testing-library/tree/bug/undefined-provider should all turn green

For more info see: https://angular.io/guide/testing#override-component-providers

Current thoughts: have a componentProviders option.
@timdeschryver timdeschryver added the bug Something isn't working label Jun 14, 2019
@timdeschryver timdeschryver mentioned this issue Jun 16, 2019
Merged
@timdeschryver
Copy link
Member Author

🎉 This issue has been resolved in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: providers on a module level testing-library/angular-testing-library
1 participant
@timdeschryver