Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for cypress v4 #118

Closed
travi opened this issue Feb 6, 2020 · 1 comment · Fixed by #119
Closed

support for cypress v4 #118

travi opened this issue Feb 6, 2020 · 1 comment · Fixed by #119
Labels
enhancement New feature or request released

Comments

@travi
Copy link
Contributor

travi commented Feb 6, 2020

  • cypress-testing-library version: v5.2.1
  • node version: v10.19.0
  • npm (or yarn) version: v6.13.4

Relevant code or config

"cypress": "^2.1.0 || ^3.0.0"

What you did:

installed v4.0.0 of cypress and ran npm ls

What happened:

slightly different versions in this project, but was the first i found with public logs: https://travis-ci.com/travi-org/theme-components/builds/147829710#L301-L313

Reproduction repository:

travi-org/theme-components#4

Problem description:

the peer ranges defined as compatible for cypress do not include v4.0.0 that was released today: https://docs.cypress.io/guides/references/changelog.html#4-0-0

Suggested solution:

add ^4.0.0 to the allowed peer ranges:

"cypress": "^2.1.0 || ^3.0.0" 
@NicholasBoll NicholasBoll added the enhancement New feature or request label Feb 6, 2020
travi added a commit to travi/cypress-testing-library that referenced this issue Feb 6, 2020
travi added a commit to travi/cypress-testing-library that referenced this issue Feb 6, 2020
NicholasBoll pushed a commit that referenced this issue Feb 6, 2020
@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants