Update @testing-library/dom version #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Bumps the
@testing-library/dom
version to^7.29.6
Why:
Currently when using the
expanded
option incy.findByRole
Typescript complains thatexpanded
is not defined in theByRoleOptions
type.Example:
This is because the
@testing-library/dom v7.28.1
that's being referenced inpackage.json
doesn't have theexpanded
property defined inqueries.d.ts
How:
I've updated the
@testing-library/dom
version inpackage.json
Checklist:
The version of
@testing-library/dom
went from7.28.1
->7.29.6
, the most significant change between those versions was adding types I think.I'd like to try it out in one of my own projects that use
cypress-testing-library
first, but I'm not really sure how to build this package locally. Some help on that would be appreciated. Or if you don't expect any issues from this, then of course it can be merged.