New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Allow Cypress 3 within peerDep. Updated Cypress and serve deps #9
chore(deps): Allow Cypress 3 within peerDep. Updated Cypress and serve deps #9
Conversation
…e deps, changed configs and scripts accordingly.
hmm, should probably wait until #7 is merged and pull master. (I developed this in pr/timeout branch and all tests passed there. Forgot to run everything again in the new branch 😕) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Once the build is passing let's merge this.
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
@@ -13,7 +13,7 @@ | |||
"test": "npm-run-all --parallel test:unit test:cypress", | |||
"test:unit": "kcd-scripts test --no-watch", | |||
"test:unit:watch": "kcd-scripts test", | |||
"test:cypress:serve": "serve --clipless --local --port 13370 ./cypress/fixtures/test-app", | |||
"test:cypress:serve": "serve -l 13370 ./cypress/fixtures/test-app", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change to shorthand? Has serve stopped supporting full nsmes for options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, oversight on my part. Long version would be --listen
They did change their API quite drastically. Since it's missing from their docs, here's the help for easy reference.
serve - Static file serving and directory listing
USAGE
$ serve --help
$ serve --version
$ serve [-l listen_uri [-l ...]] [directory]
By default, serve will listen on 0.0.0.0:3000 and serve the
current working directory on that address.
Specifying a single --listen argument will overwrite the default, not supplement it.
OPTIONS
--help Shows this help message
-v, --version Displays the current version of serve
-l, --listen listen_uri Specify a URI endpoint on which to listen (see below) -
more than one may be specified to listen in multiple places
-d, --debug Show debugging information
-s, --single Rewrite all not-found requests to `index.html`
ENDPOINTS
Listen endpoints (specified by the --listen or -l options above) instruct serve
to listen on one or more interfaces/ports, UNIX domain sockets, or Windows named pipes.
For TCP ports on hostname "localhost":
$ serve -l 1234
For TCP (traditional host/port) endpoints:
$ serve -l tcp://hostname:1234
For UNIX domain socket endpoints:
$ serve -l unix:/path/to/socket.sock
For Windows named pipe endpoints:
$ serve -l pipe:\\.\pipe\PipeName
Why:
Cypress 3 has been released on 5/29/2018 (changelog).
What:
peerDependencies
to allow Cypress 3devDependencies
devDependencies
Checklist:
Locally, I'm having an issue with
npm run validate
not exiting. Everything passes, but the process doesn't exit. Curious to see if it also happens in Travis.