Prioritize aria names over hidden in byRole queries

testing-library · Oct 24, 2021 · a361d1b · a361d1b
1 parent b6b9b5b
commit a361d1b
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/queries/role.js b/src/queries/role.js
@@ -153,13 +153,6 @@ function queryAllByRole(
       // don't care if aria attributes are unspecified
       return true
     })
-    .filter(element => {
-      return hidden === false
-        ? isInaccessible(element, {
-            isSubtreeInaccessible: cachedIsSubtreeInaccessible,
-          }) === false
-        : true
-    })
     .filter(element => {
       if (name === undefined) {
         // Don't care
@@ -176,6 +169,13 @@ function queryAllByRole(
         text => text,
       )
     })
+    .filter(element => {
+      return hidden === false
+        ? isInaccessible(element, {
+            isSubtreeInaccessible: cachedIsSubtreeInaccessible,
+          }) === false
+        : true
+    })
 }
 
 function makeRoleSelector(role, exact, customNormalizer) {