fix(byRole): Don't assume window context #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Get window from passed element
Why:
element might be passed from another window/frame
How:
Use
element.ownerDocument.defaultView
. This is safe to evaluate since we expect anElement
.ownerDocument
is onlynull
forDocument
(https://developer.mozilla.org/en-US/docs/Web/API/Node/ownerDocument)Checklist:
[ ] Documentation added to thedocs site
this
) but only from the window of the passed element (at least thejsdom
implementation). So from my knowledge this is only useful if you run inside node without a global DOM.