Skip to content

fix(byRole): Don't assume window context #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2019
+21 −0
Merged

fix(byRole): Don't assume window context #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bf321
fix(shouldExcludeFromA11yTree): Don't assume window contextg
eps1lon Oct 10, 2019
4bbbb4c
Add test
eps1lon Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/__node_tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,23 @@ test('works without a browser context on a dom node (JSDOM Fragment)', () => {
/>
`)
})

test('byRole works without a global DOM', () => {
const {
window: {
document: {body: container},
},
} = new JSDOM(`
<html>
<body>
<button>Say "Hello, Dave!"</button>
</body>
</html>
`)

expect(dtl.getByRole(container, 'button')).toMatchInlineSnapshot(`
<button>
Say "Hello, Dave!"
</button>
`)
})
1 change: 1 addition & 0 deletions src/role-helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const elementRoleList = buildElementRoleList(elementRoles)
* @returns {boolean} true if excluded, otherwise false
*/
function shouldExcludeFromA11yTree(element) {
const window = element.ownerDocument.defaultView
const computedStyle = window.getComputedStyle(element)
// since visibility is inherited we can exit early
if (computedStyle.visibility === 'hidden') {
Expand Down