Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve suggested message, can't await getBy #655

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

timdeschryver
Copy link
Member

What:

  • Improve suggestion when a Promise is passed to a fireEvent method

Why:

  • A getBy query can't be awaited and the messages says await screen.getBy

How:

  • Change the message (and the test)

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@timdeschryver
Copy link
Member Author

If needed, I can undo the style changes - but it seems like it's correctly formatted now?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64e5685:

Sandbox Source
xenodochial-beaver-eki2f Configuration

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #655 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #655   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          582       582           
  Branches       149       149           
=========================================
  Hits           582       582           
Impacted Files Coverage Δ
src/helpers.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55344ea...64e5685. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍

@kentcdodds kentcdodds merged commit 18b1623 into master Jun 20, 2020
@kentcdodds kentcdodds deleted the pr/promise-message branch June 20, 2020 16:26
@kentcdodds
Copy link
Member

Thanks!

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.16.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants