feat: Add extra error messages when screen was passed instead of a DOM element
#949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first step for fix issue: Output User Error instead of New Issue error for wrong node from user getWindowFromNode(node) addresses issue testing-library#911
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84aaba9:
|
…ror for wrong node from user - by adding additional check and correct error-message according to edge use case from the issue testing-library#911
savcni01
changed the title
eps1lon
reviewed
May 5, 2021
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
eps1lon
requested changes
May 6, 2021
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
eps1lon
changed the title
eps1lon
approved these changes
May 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #949 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 962 966 +4
Branches 290 293 +3
=========================================
+ Hits 962 966 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eps1lon
changed the title
screen was passed instead of a DOM element
|
@savcni01 Thanks! |
|
🎉 This PR is included in version 7.31.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is fix #911
When the user provides the wrong query (
screeninstead of a real query, we can output a clear, user-friendly error instead of general (and not relevant) - Create a new issue error.Checklist:
docs site