Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): move typings to DefinitelyTyped #337

Merged
merged 2 commits into from
Aug 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"module": "dist/@testing-library/dom.esm.js",
"umd:main": "dist/@testing-library/dom.umd.js",
"source": "src/index.js",
"typings": "typings",
"keywords": [
"testing",
"ui",
Expand All @@ -30,28 +29,26 @@
"test:update": "npm test -- --updateSnapshot --coverage",
"test:debug": "node --inspect-brk ./node_modules/.bin/jest --watch --runInBand",
"validate": "kcd-scripts validate",
"setup": "npm install && npm run validate -s",
"dtslint": "dtslint typings"
"setup": "npm install && npm run validate -s"
},
"husky": {
"hooks": {
"pre-commit": "kcd-scripts pre-commit"
}
},
"files": [
"dist",
"typings"
"dist"
],
"dependencies": {
"@babel/runtime": "^7.5.5",
"@sheerun/mutationobserver-shim": "^0.3.2",
"@types/testing-library__dom": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I've added this as a dep. Here's what things look like before any of these changes (with the current 6.0.0):

Screen Shot 2019-08-15 at 1 01 14 PM

And here's what it looks like before I added this dependency (with 6.0.1-alpha.0):

Screen Shot 2019-08-15 at 1 00 12 PM

And here's what it looks like after I added this dependency (with 6.0.1-alpha.1):

Screen Shot 2019-08-15 at 1 00 32 PM

So as far as the consumer is concerned, there's absolutely no change. And if someone wants to have more control over the version of the typings, then they can install @types/testing-library__dom themselves and npm or yarn will de-dupe to whatever version they want.

This is getting a 👍 from me. Let's do it!

"aria-query": "3.0.0",
"pretty-format": "^24.8.0",
"wait-for-expect": "^1.3.0"
},
"devDependencies": {
"@testing-library/jest-dom": "^4.0.0",
"dtslint": "^0.9.1",
"jest-in-case": "^1.0.2",
"jest-serializer-ansi": "^1.0.3",
"jest-watch-select-projects": "^0.1.1",
Expand Down
10 changes: 0 additions & 10 deletions typings/config.d.ts

This file was deleted.

102 changes: 0 additions & 102 deletions typings/events.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion typings/get-node-text.d.ts

This file was deleted.

33 changes: 0 additions & 33 deletions typings/get-queries-for-element.d.ts

This file was deleted.

20 changes: 0 additions & 20 deletions typings/index.d.ts

This file was deleted.

31 changes: 0 additions & 31 deletions typings/matches.d.ts

This file was deleted.

7 changes: 0 additions & 7 deletions typings/pretty-dom.d.ts

This file was deleted.

116 changes: 0 additions & 116 deletions typings/queries.d.ts

This file was deleted.