Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logPlaygroundUrl in screen #781

Merged
merged 5 commits into from Oct 13, 2020
Merged

feat: add logPlaygroundUrl in screen #781

merged 5 commits into from Oct 13, 2020

Conversation

balavishnuvj
Copy link
Contributor

Based on discussion at #780

@balavishnuvj
Copy link
Contributor Author

Do let me know what you think of this. This mostly PRd version of what @smeijer had suggested.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d773f84:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration

marcosvega91
marcosvega91 requested changes Oct 12, 2020
View reviewed changes
Copy link
Member

@marcosvega91 marcosvega91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @balavishnuvj thanks for this implementation 💯 . I have added some comments

src/screen.js Outdated Show resolved Hide resolved
src/screen.js Outdated Show resolved Hide resolved
@balavishnuvj
Copy link
Contributor Author

Hi @marcosvega91 , thank you reviewing so quick. Have addressed your concerns :)

@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited

Codecov Report

Merging #781 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #781   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          703       725   +22     
  Branches       183       188    +5     
=========================================
+ Hits           703       725   +22
Impacted Files Coverage Δ
src/screen.js 100.00% <100.00%> (ø)
src/wait-for.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cfef8...d773f84. Read the comment docs.

marcosvega91
marcosvega91 previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@marcosvega91 marcosvega91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

kentcdodds
kentcdodds previously approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super! 👏 Just one little thing that I can merge myself. Thank you :)

src/__tests__/screen.js Outdated Show resolved Hide resolved
@kentcdodds kentcdodds dismissed stale reviews from marcosvega91 and themself via 5a110de October 12, 2020 21:29
kentcdodds
kentcdodds reviewed Oct 12, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcosvega91 reminded me that we should do TS updates on this PR. You up for that @balavishnuvj?

@balavishnuvj
Copy link
Contributor Author

@kentcdodds I have tried to update the types. All the t.ds files were giving parsing error. So not sure if this defination works.

kentcdodds
kentcdodds approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👏

@kentcdodds kentcdodds merged commit f627ade into testing-library:master Oct 13, 2020
@testing-library-bot
Copy link

🎉 This PR is included in version 7.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@balavishnuvj
Copy link
Contributor Author

@all-contributors please add @balavishnuvj for code

@allcontributors allcontributors bot mentioned this pull request Oct 13, 2020
Merged
@allcontributors
Copy link
Contributor

@balavishnuvj

I've put up a pull request to add @balavishnuvj! 🎉

@MichaelDeBoey MichaelDeBoey mentioned this pull request Mar 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@marcosvega91 marcosvega91 marcosvega91 left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balavishnuvj @testing-library-bot @kentcdodds @marcosvega91