Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: PrettyFormatOptions -> PrettyDOMOptions #984

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 20, 2021

What:

In response to #979 (comment). Follow-up to #907

Why:

These options are passed to prettyDOM not pretty-format

How:

Rename PrettyFormatOptions -> PrettyDOMOptions

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f995f3c:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #984 (f995f3c) into alpha (f78d289) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #984   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          914       914           
  Branches       281       281           
=========================================
  Hits           914       914           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78d289...f995f3c. Read the comment docs.

@eps1lon eps1lon merged commit 4c58bc9 into testing-library:alpha Jun 20, 2021
@eps1lon eps1lon deleted the chore/pretty-format-options branch June 20, 2021 08:08
@github-actions
Copy link

🎉 This PR is included in version 8.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant