Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: downgrade codecov/codecov-action #345

Merged
merged 1 commit into from
Mar 21, 2024
Merged

ci: downgrade codecov/codecov-action #345

merged 1 commit into from
Mar 21, 2024

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Mar 21, 2024

What:

This reverts commit 575a831.

Why:

The v4 action seems to be broken; it might be a case of just setting up a token but I can't do that and also it seems like that might not always solve the problem.

Since this is a required status check that cannot be overridden (at least by me), it's blocking PRs.

How:

By reverting #325

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@G-Rath
Copy link
Collaborator Author

G-Rath commented Mar 21, 2024

@MichaelDeBoey I think you're going to have to forcefully land this since codecov is a required status check (unless I can push directly to main - I assume not but have not actually tried 😅)

Nope I'm silly, I have more permissions than I realised 🤦

@G-Rath G-Rath merged commit 0cf0522 into main Mar 21, 2024
58 of 60 checks passed
@G-Rath G-Rath deleted the downgrade-codecov branch March 21, 2024 19:01
Copy link

🎉 This PR is included in version 5.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant